Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Use fully-qualified type names in proc macro. #3544

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Use fully-qualified type names in proc macro. #3544

wants to merge 1 commit into from

Conversation

mnett82
Copy link
Contributor

@mnett82 mnett82 commented Jan 4, 2022

Modifies the code emitted by derive_label to use fully-qualified type
names (e.g. std::boxed::Box instead of Box).

Objective

  • Using unqualified types here causes errors when the proc macro is used in contexts that locally define types with conflicting names (e.g. a local definition of Box).

Solution

  • Fully qualify standard types emitted by the proc macro code.

@mnett82
Use fully-qualified type names in proc macro.
53e76fc 
Modifies the code emitted by `derive_label` to use fully-qualified type
names (e.g. `std::boxed::Box` instead of `Box`).
@github-actions github-actions bot added the S-Needs-Triage This issue needs to be labelled label Jan 4, 2022
@alice-i-cecile alice-i-cecile added A-Core Common functionality for all bevy apps C-Code-Quality A section of code that is hard to understand or change S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Triage This issue needs to be labelled labels Jan 4, 2022
@mnett82
Copy link
Contributor Author

mnett82 commented Jan 4, 2022 •
edited
Loading

Thanks for the review!

bors r+ (It appears I misunderstood who is supposed to trigger Bors -- will wait for someone to get around to it)

@bors
Copy link
Contributor

bors bot commented Jan 4, 2022

🔒 Permission denied

Existing reviewers: click here to make mnett82 a reviewer

@alice-i-cecile
Copy link
Member

bors r+ (It appears I misunderstood who is supposed to trigger Bors -- will wait for someone to get around to it)

Yep, this is currently scoped to @cart (full rights), @mockersf (trivial code quality improvements) and myself (docs!). In this case, this PR is in the second group, so @mockersf will likely be the one to merge this in.

@cart
Copy link
Member

cart commented Jan 4, 2022

bors r+

bors bot pushed a commit that referenced this pull request Jan 4, 2022
@mnett82
Use fully-qualified type names in proc macro. (#3544)
1a2646e 
Modifies the code emitted by `derive_label` to use fully-qualified type
names (e.g. `std::boxed::Box` instead of `Box`).

# Objective

- Using unqualified types here causes errors when the proc macro is used in contexts that locally define types with conflicting names (e.g. a local definition of `Box`).

## Solution

- Fully qualify standard types emitted by the proc macro code.
@bors
Copy link
Contributor

bors bot commented Jan 4, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Use fully-qualified type names in proc macro. [Merged by Bors] - Use fully-qualified type names in proc macro. Jan 4, 2022
@bors bors bot closed this Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mockersf mockersf mockersf approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-Core Common functionality for all bevy apps C-Code-Quality A section of code that is hard to understand or change S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mnett82 @alice-i-cecile @cart @mockersf